Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MAJOR): Refactor module vpc, remove module subnet_set #68

Merged
merged 38 commits into from
Aug 29, 2024
Merged

feat(MAJOR): Refactor module vpc, remove module subnet_set #68

merged 38 commits into from
Aug 29, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Aug 5, 2024 •
edited
Loading

Description

Resolves #62 by:

  • remove subnet_set module
  • extend vpc module to create subnets and route tables
  • simplify subnets creation (not using complex locals from subnet_set module)
  • adjust the variables in variables.tf and outputs inoutputs.tf in order that makes sense
  • refactor variables e.g. create new variable internet_gateway, which defines object with attributes for IGW creation/usage
  • adjust variables description to standard from Major refactor for modules and examples #53
  • add a comment with a link to Terraform Registry before a resource block
  • adjust all examples to new approach with vpc module
  • adjust CloudNGFW examples to changes delivered for other examples in fix(examples): Refactor examples for reference architectures #49
  • change approach for CloudWatch logs group in CloudNGFW (as the same name PaloAltoCloudNGFW has to be used for both examples, groups was created on account used in workflows and in TFVARS we are not creating new log group, we are reusing existing one)
  • enables pre-releases from rc branch

This PR is first iteration of vpc refactor - still needs to be done in another PR e.g.:

  • added support for all possible attributes for every resource used in module
  • README changed to new standard with new file .header.md

Motivation and Context

#53

How Has This Been Tested?

Code was tested locally and via ChatOps.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech
Remove subnet_set module, extend VPC module to create subnets and rou…
04d8d69 
…te tables, adjust combined_design to new approach
@sebastianczech
Remove commented code
9497473
@sebastianczech
Merge branch 'main' into refactor_vpc_subnet
3def699
@sebastianczech
Extend tests to check if TF version is supported
32ce885
@sebastianczech
Extend tests for module to check if TF version is supported
591ac6d
@sebastianczech
Change order or resources and variables, add URLs to TF registry for …
6354880 
…each resource, simplify locals, remove comments
@sebastianczech
Extend types for security groups and NACL (instead of any)
9e12884
@sebastianczech
Fix problem with VPC routes
05af310
@sebastianczech
Remove try() from module vpc
d203b1d
@sebastianczech
Merge main and change group to subnet_group
ec13310
@sebastianczech
Refactor all variables of vpc module, including variables description
dfbf90c
@sebastianczech
Adjust combined design autoscale example
ac64367
@sebastianczech
Adjust centralized design example
8fe80d7
@sebastianczech
Adjust centralized design autoscale example
b4ed40c
@sebastianczech
Adjust 2 isolated design, Panorama and VM-Series examples
051dc68
@sebastianczech
Fix terratest for VM-Series
03abe62
@sebastianczech
Merge branch 'main' into refactor_vpc_subnet
78000c6
@sebastianczech
Adjust cloud NGGW combined design example
56b5a79
@sebastianczech
Adjust cloud NGGW isolated design example
3886228
@sebastianczech
Fix Terratest
d7f01ec
@sebastianczech
Fix problem with IPv6 for subnets
18b8c5d
@sebastianczech
Fix problem with AZ in Panorama example
24c4e5e
@sebastianczech
Fix problem with NATGW
44a7a67
@sebastianczech
Fix CloudNGFW subnets
6c9c1da
@sebastianczech
Use different CloudWatch log groups for 2 examples with CloudNGFW
0725c9a
@sebastianczech
Use existing CloudWatch log group with the same name for both example…
b3f3501 
…s for CloudNGFW
@sebastianczech
Merge changes from main
c0800b5
@sebastianczech sebastianczech requested a review from a team as a code owner August 5, 2024 12:14
@sebastianczech sebastianczech requested review from a team and removed request for a team August 5, 2024 12:14
@sebastianczech sebastianczech linked an issue Aug 5, 2024 that may be closed by this pull request
Refactor subnet_set and vpc modules #62
Closed
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 5, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10248610526
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

All idempotence tests were executed also in #63

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 5, 2024 •
edited by github-actions bot
Loading

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale"

Testing job ID: 10248963837
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 5, 2024 •
edited by github-actions bot
Loading

/idempotence paths="examples/panorama_standalone examples/vmseries_standalone"

Testing job ID: 10249380073
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 5, 2024 •
edited by github-actions bot
Loading

/idempotence paths="examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10249711908
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 9, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10315918212
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 9, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10316032087
Job result: FAILURE

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 9, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10316201752
Job result: SUCCESS

@sebastianczech sebastianczech changed the title feat(MAJOR): Refactor module vpc, remove module subnet_set feat(MAJOR): Refactor module vpc, remove module subnet_set Aug 13, 2024
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 14, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10387029860
Job result: SUCCESS

michalbil
michalbil approved these changes Aug 27, 2024
View reviewed changes
modules/vpc/main.tf Outdated Show resolved Hide resolved
modules/vpc/main.tf Outdated Show resolved Hide resolved
modules/vpc/main.tf Outdated Show resolved Hide resolved
modules/vpc/main.tf Outdated Show resolved Hide resolved
modules/vpc/variables.tf Outdated Show resolved Hide resolved
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 27, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10579837805
Job result: SUCCESS

@migara migara merged commit 1c4112b into rc Aug 29, 2024
@migara migara deleted the refactor_vpc_subnet branch August 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbil michalbil michalbil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor subnet_set and vpc modules
3 participants
@sebastianczech @michalbil @migara