feat: new AWS IAM module #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbil
reviewed
Oct 21, 2024
| account_id = data.aws_caller_identity.this.account_id | ||
| delicense_param = try(startswith(var.delicense_ssm_param_name, "/") ? var.delicense_ssm_param_name : "/${var.delicense_ssm_param_name}", null) | ||
|
|
||
| lambda_execute_policy = { |
There was a problem hiding this comment.
Suggested change
| lambda_execute_policy = { | |
| lambda_execute_policies = { |
There was a problem hiding this comment.
hmm, from AWS perspective - it is a one policy with many statements
| } | ||
| } | ||
|
|
||
| lambda_delicense_policy = { |
There was a problem hiding this comment.
Suggested change
| lambda_delicense_policy = { | |
| lambda_delicense_policies = { |
| default = false | ||
| } | ||
|
|
||
| variable "create_bootrap_policy" { |
There was a problem hiding this comment.
As with instance profile - proposal to either merge this into a single var or rely on bucket name.
Co-authored-by: michalbil <[email protected]>
Co-authored-by: michalbil <[email protected]>
lstadnik
commented
Oct 24, 2024
There was a problem hiding this comment.
Thanks @michalbil for suggestion - "plurals" and "create" we can rediscuss offline
modules/iam/variables.tf
Outdated
Comment on lines
28
to
38
| variable "create_instance_profile" { | ||
| description = "Create an instance profile." | ||
| type = bool | ||
| default = false | ||
| } | ||
|
|
||
| variable "profile_instance_name" { | ||
| description = "A profile instance name." | ||
| type = string | ||
| default = null | ||
| } |
There was a problem hiding this comment.
I think - using create variable - gives more flexibility. The module can use data source for existing instance_profile_name = 'name' - The name providing only is less initiative and also different modules are using this approach.
Co-authored-by: michalbil <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces new module for AWS repo - It supports pre-defined collection of used IAM policies and custom made policies as well.
Motivation and Context
#53 issue presents required changes for major refactor of existing code.
How Has This Been Tested?
The IAM modules should be tested against all examples.
Types of changes
Checklist