Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Bot doesn't seem to count users in channel not playing anything #12

Open
chrys-the-flower opened this issue Jan 16, 2021 · 3 comments
Open

Comments

@chrys-the-flower
Copy link

I'm not sure if this is intended functionality but the bot will set the channel name if one person is playing a game but two people are not. I have it set to majority 60 which I thought would leave the channel name at default unless 60%+ were playing the same game.

@Pigpog
Copy link
Owner

Pigpog commented Jan 16, 2021

Sorry about that, this bot is currently a mess. I'm currently hosting 3 slightly different instances.

I'll assume you're using the instance with the white remote icon. The white instance ignores the majority value altogether, and rather than use percentages, it chooses the game with the highest count of users playing in the voice chat. This was suggested by a user with the rationale that users would rather it display a game than nothing in all cases.

Unfortunately, the black icon instance (with the expected functionality) cannot be added to more servers because it has exceeded 100 servers. I really should make the instances consistent, or at the very least remove the majority command and its help message from the white instance if it isn't gonna use it. I neglect this project because the change that discord made to their API (ratelimited to 2 channel name changes per 10 minutes) make it really painful to test anything for this bot, and I have moved on to new projects. I'll consider how I will go about fixing this, and hopefully I can reach an agreeable compromise.

Thanks for checking out my bot and sorry for the inconvenience!

@chrys-the-flower
Copy link
Author

No worries, thanks for answering so quickly.

Yeah I am using the one with the white icon, so that would explain why that happens. It also explains why the bot sometimes seemed to take a while to update the game, and certainly sounds like a pain to test. Maybe while testing it could have a debug mode that would send messages to a text channel of what it would change the channel name to since it seems the function that sets the channel name works reliable so far from what I can tell.

If you're looking for a compromise, would it be possible to let users set what mode they want the bot to use? Maybe change the !majority command to something like !mode? That way users could run something like '!mode majority %' or '!mode playercount' instead of needing to choose one other the other.

@Pigpog
Copy link
Owner

Pigpog commented Jan 17, 2021

Maybe while testing it could have a debug mode that would send messages to a text channel of what it would change the channel name to

That's what I thought of too a couple hours after posting my comment lol. That makes things so much easier.

set what mode they want the bot to use?

I thought of this while writing but didn't include it because I didn't wanna bore you with details or commit to any one specific solution, but I think that's exactly what I will do.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants