-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Sort playlists #48
Comments
Implemented in d1a2e90 @efb4f5ff-1298-471a-8973-3d47447115dc help me test~ |
Filter is visible when the user only has one playlist. Not very usefull to the user to show it if they cant use it. I would suggest showing the filter when user has more than 1 playlist |
Just created 3 playlist to set a baseline for the filters
VirtualBoxVM_8Pq9eSkNar.mp4Changed playlist name
LC changed even though this has nothing to do with LC VirtualBoxVM_HkctpmyIy0.mp4Removing a video in the playlist does not give it the first spot when sorted by latest updated VirtualBoxVM_XeWVkMEcoD.mp4 |
You makes me find a bug where the updates to playlists are not partial (but complete replace) when updating playlists Now should be all fixed Details for nedb partial update op: const Datastore = require("@seald-io/nedb")
const db = new Datastore()
await db.insertAsync({ _id: 1, videos: [], name: "111", lastUpdatedAt: 9999 })
console.log(await db.findAsync({ _id: 1 }))
await db.updateAsync({ _id: 1 }, { $set: { lastUpdatedAt: 8888 } }, { upsert: true })
console.log(await db.findAsync({ _id: 1 }))
await db.updateAsync({ _id: 2 }, { $set: { lastUpdatedAt: 8888 } }, { upsert: true })
console.log(await db.findAsync({ _id: 2 }))
await db.updateAsync({ _id: 1 }, { lastUpdatedAt: 8888 }, { upsert: true })
console.log(await db.findAsync({ _id: 1 }))
await db.updateAsync({ _id: 1 }, { _id: 1, lastUpdatedAt: 8888 }, { upsert: true })
console.log(await db.findAsync({ _id: 1 })) |
Sorry for taking so long. That bug is indeed solved now.
Random thought would be a nice to have to see the filters in the playlist view and maybe in add to playlist view |
Forgot, see 69406b2 which changed logic for filter input AND sort select Recently Created/Updated? (But what about Earliest...
You mean... add filter in "add to playlist view"? |
LGTM
Recently Updated sounds better to me. Ugh idk what to do about earliest...
Sorry for the confusion. It would be nice to also see the sort by in the following views VirtualBoxVM_dEdHQWnxII.mp4 |
(Not this issue related) Let me know if you find any regression (I hope not |
Add playlists sort order for last played at (local playlists only) |
Will come back to this later today this will take me a bit longer to test! |
i think u meant to link bdd002a |
LGTM LGTM Everything seems to be sorted correctly so LGTM LGTM
LGTM
I do not see anything weird so LGTM but if i do i'll let u know! Could u also add the sort by dropdown when u go into one of your local playlist the ones that will fit are
|
I rather do it in v2... |
I think u mean the opposite. Im requesting sorting videos in playlist but this feature request is about sorting playlists. You're right that this isnt the right place to ask for it but im going to push back a little because i think that this is a very valuable thing to add in v1 |
For I understand it's valuable but I don't guarantee implementing it in v1 and probably not in initial PR (nice to have, won't upset user too much if absent things) Anyway, put that into another issue |
Sure, Everything in here LGTM so closing |
Oh lol this is your issue cant close |
Oops |
Guidelines
Problem Description
Cannot sort playlist in playlists view
Proposed Solution
Add sort dropdown in playlists view
Alternatives Considered
Issue Labels
improvement to existing feature
Additional Information
No response
The text was updated successfully, but these errors were encountered: