Removed dependency on SDL2, making it easier to build #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Merging. |
|
I feel this config should be the default for the user input example instead of SDL2. So noobs like myself do not run into issues when they go to build. Though I did figure out how to workaround it by modifying the cargo.toml after seeing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
piston-examplescurrently requires SDL2, which is somewhat painful on Windows (see #391, #405). This PR removes that dependency and solves both of these issues.The downside is that there no longer is an example that uses SDL2, but the code difference is so small that it seems like an OK trade-off to me.