Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace type tags on PMap and PValue and use newtypes instead #780

Open
kozross opened this issue Dec 2, 2024 · 1 comment
Open

Replace type tags on PMap and PValue and use newtypes instead #780

kozross opened this issue Dec 2, 2024 · 1 comment
Labels
api enhancement New feature or request

Comments

@kozross
Copy link
Contributor

kozross commented Dec 2, 2024

Instead of the current tag-driven system, we would have something like this:

  • PUnsortedMap
  • PSortedMap
  • PMintingValue (implies sorted, no mandatory Ada)
  • PLedgerValue (implies sorted, mandatory Ada)
  • PRawValue (no guarantees)
@kozross kozross added enhancement New feature or request api labels Dec 2, 2024
@t4ccer
Copy link
Collaborator

t4ccer commented Dec 3, 2024

PMintingValue (implies sorted, no mandatory Ada)

You need to split these in two, V1 and V2 PMintingValue implies mandatory zero ADA and non-zero everything else, V3 PMintingValue implies no ADA entry at all, and everything else non-zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants