Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose property to retrieve validatable/submittable elements #236

Open
valdrinkoshi opened this issue Jan 23, 2018 · 3 comments
Open

Expose property to retrieve validatable/submittable elements #236

valdrinkoshi opened this issue Jan 23, 2018 · 3 comments

Comments

@valdrinkoshi
Copy link
Member

<iron-form> contains all the complex logic of searching for the validatable and submittable elements. It would be really helpful for it to expose a public method/property to retrieve these.
@notwaldorf WDYT about making _getValidatableElements & _getSubmittableElements public?

@web-padawan
Copy link

BTW, consider also creating separate helper similar to iron-focusables-helper. This would allow to re-use some logic of iron-form without pulling in the element itself.

@notwaldorf
Copy link
Contributor

I don't have any huge objections to making them public, other that they will become part of the public API, and thus harder to maintain (no breaking changes, etc). Is there a benefit to having them public vs protected, like they are now?

@vdegenne
Copy link

@valdrinkoshi What about this type of helper that simulates native form.elements ? (#273)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants