Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 404 page #1

Open
Potherca opened this issue Feb 1, 2014 · 1 comment
Open

Add a 404 page #1

Potherca opened this issue Feb 1, 2014 · 1 comment
Labels

Comments

@Potherca
Copy link
Owner

Potherca commented Feb 1, 2014

A 404.html page needs to be added to avoid the github default 404 users will encounter on mishaps. This will most often be the case when a githup project does not have a gh-pages branch.

One question that needs addressing is that, when a project on github does have a gh-pages branch, and a user goes 404, will it show the 404 from here or do we need to add our 404.html to all of our projects?

@Potherca
Copy link
Owner Author

Potherca commented Feb 1, 2014

If I understand this correctly:

Custom 404s will only work if a custom domain is used, otherwise the User Pages 404 is used.

We should be fine untill we start adding custom domains to project gh-pages branches.

@Potherca Potherca added the ready label May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant