Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exports of entry points with relative paths are not getting added to the import map #773

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 17, 2021 · 1 comment · Fixed by #749
Closed
1 of 5 tasks
Assignees
Labels
alpha.0 bug Something isn't working CLI v0.18.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Oct 17, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As observed as part of integrating Material Web Components in ProjectEvergreen/greenwood-getting-started#42, that Greenwood was not able to resolve one if the dependencies completely

image

Details

Looking deeper, it looks like this is a case where the @material/base packages' entry point does an export * of other files in the package but we're not handling them if they are relative (e.g. path starts with a ./)

export * from './component';
export * from './foundation';
export * from './types';

We should be surfacing these as entries into the import map.

@thescientist13 thescientist13 added bug Something isn't working CLI labels Oct 17, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 17, 2021
@thescientist13 thescientist13 self-assigned this Oct 17, 2021
@thescientist13
Copy link
Member Author

For the sake of convenience since I need all the setup from #748, will tack the change onto #749

@thescientist13 thescientist13 changed the title exports of entry points without extensions are not getting added to the import map exports of entry points with relative paths are not getting added to the import map Oct 17, 2021
thescientist13 added a commit that referenced this issue Oct 20, 2021
… entry points (#749)

* better import map filtering and add test cases

* issue #773 handle relative path exports from dependency entry points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 bug Something isn't working CLI v0.18.0
Projects
None yet
1 participant