player.bartenderQuestLog is not synced in SyncPlayer/PlayerInfo packet

[tanpro260196]

Some player on my server have informed me a way to have infinite Defender's Medal from the Tavernkeep.
The first time you talk to him (Tavernkeep) he will give you 5 medals.

On Single map, you will have to wait untill the next day to get another 5. But on my server, player only need to exit the server and join again to get another 5.

Not sure if this is a Terraria bug or tshock bug, but it only happen on the Server.

Using lastest tshock stable.

[ivanbiljan]

I wasn't able to reproduce this. @tanpro260196 please check if it's still an issue.

[Victorsueca]

It is still an issue, happened to me just now, writing this with terraria open. Apparently logging out and then in to the server causes the guy to forget he just gave you 5 medals. Using the same character, connecting from the same IP and using the same server-side account login.

[ivanbiljan]

I tested it again and still can't reproduce the issue.

[Victorsueca]

I made a video where I get to reproduce it

[tanpro260196]

As far as I know, it need to be a new character and server must use ssc.

[Victorsueca]

Indeed, the server on the video is using SSC and the character I used has never been used in another server or singleplayer world.

[MarioE]

This seems to be the case because the player file isn't saved in SSC, which means the flag that the character has talked to the bartender is never saved. So the character can keep getting the defender medals. There doesn't seem to be a great solution to this, besides asking the devs to send the flag to servers.

[Ijwu]

Sounds like we know what may be causing this now and can only hope to make Re-Logic aware and discuss a possible solution.

[QuiCM]

@hakusaro Do you know if Re-Logic are aware of this? Is this something we can request?

[hakusaro]

@QuiCM requested sync, will report back later.

[hakusaro]

Status is now RL-MaybeAccepted.

[bartico6]

This issue is now partially fixed as of 1.4.

Non SSC servers are completely covered - there is a check in game code that makes sure you can't spawn it more than once per character.

SSC servers.... are not so lucky. The flag for whether or not you have talked to the tavernkeep is saved to the player file.... which is not saved if you're in SSC mode. So, fresh characters that never talked to the tavernkeep will continue to be able to infinitely spawn medals, while those who have already talked to him outside of SSC will not.

This appears to be intentional, too, so I think this issue can be closed now.

[Shrizt]

this is still issue in SSC TShock latest.
Is there other open topic or this need to be continued.
How to avoid players to cheat if SSC?

[drunderscore]

@Shrizt You are unfortunately correct, this is still an issue for SSC, though noted above is that it seems intentional by Re-Logic... however I'd still be willing to transfer and re-open this on Pryaxis/Terraria where Terraria-specific issues live.

I'll think about it and likely move it in just a bit.

[Shrizt]

If there are no possibility to fix on server side - should be some workaround - like disabling this 5 medals initial award or bartender at all, as taking medals you may buy items and then sell them for gold, which is totally inacceptable.
Any more ideas?
Thanks for re-opening, that bother a lot. My kids found it and using :)

[drunderscore]

@Shrizt No, there is no possible workaround, hence the title and labels of this PR.