Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skipOver in uriToFile #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nordlow
Copy link

@nordlow nordlow commented Nov 19, 2024

No description provided.

@WebFreak001
Copy link
Member

the return variable ret has been removed, also the decodeComponent part on the remainder of the URL (which in hindsight might not be the optimal place, but idk if there are tests for it why I added it in the first place)

@nordlow
Copy link
Author

nordlow commented Nov 19, 2024

the return variable ret has been removed, also the decodeComponent part on the remainder of the URL (which in hindsight might not be the optimal place, but idk if there are tests for it why I added it in the first place)

Fixed.

@nordlow
Copy link
Author

nordlow commented Nov 19, 2024

Failure in

Run Unittests / Dub Tests (macos-latest, ldc-latest) (pull_request) Failing after 3m 

seems unrelated. How do move forward?

@nordlow
Copy link
Author

nordlow commented Nov 21, 2024

Ping, @WebFreak001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants