Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for english version and fixed typos. #332

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added example for english version and fixed typos. #332

wants to merge 5 commits into from

Conversation

abadoni5
Copy link
Contributor

@abadoni5 abadoni5 commented Mar 12, 2024 •
edited
Loading

Summary

Closes #331, There is example in the English tutorial.
This PR aims to fix that.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

Screenshot 2024-03-13 at 5 12 20 AM

@abadoni5
Copy link
Contributor Author

abadoni5 commented Mar 12, 2024 •
edited
Loading

@NicolasSandoval, PR#228 seems to be incomplete. This is PR aims to fix all that in order to remove inconsistencies from the website.

@github-actions GitHub Actions
Copy link

Published to http://pyar.github.io/PyZombis/332/index.html

fzuccolo
fzuccolo reviewed Mar 13, 2024
View reviewed changes
build_info Outdated Show resolved Hide resolved
fzuccolo
fzuccolo reviewed Mar 13, 2024
View reviewed changes
_sources/lectures/TWP40/TWP40_12.rst Outdated
@@ -21,14 +21,16 @@ Conversión de grados usando C
printf("Celsius: %2.1f\n", C);
}

Conversión de grados usando Python
Convirtiendo grados usando Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Conversión de is OK so we are consistent with the title in line 9.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fzuccolo I have changed the mentioned line so we are now consistent according to line 9.

@github-actions GitHub Actions
Copy link

Published to http://pyar.github.io/PyZombis/332/index.html

@github-actions GitHub Actions
Copy link

Published to http://pyar.github.io/PyZombis/332/index.html

1 similar comment
@github-actions GitHub Actions
Copy link

Published to http://pyar.github.io/PyZombis/332/index.html

@github-actions GitHub Actions
Copy link

Published to http://pyar.github.io/PyZombis/332/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzuccolo fzuccolo fzuccolo approved these changes

@diivi diivi diivi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python example for converting degrees in [TWP_40_12_en]
3 participants
@abadoni5 @diivi @fzuccolo