Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify QuantEcon.py and QuantEcon.jl APIs? #663

Open
1 of 2 tasks
Smit-create opened this issue Dec 6, 2022 · 6 comments
Open
1 of 2 tasks

Unify QuantEcon.py and QuantEcon.jl APIs? #663

Smit-create opened this issue Dec 6, 2022 · 6 comments

Comments

@Smit-create
Copy link
Member

Smit-create commented Dec 6, 2022

One of the APIs that differ in julia and python versions is: tauchen.
Julia version is: Doc1
Python version is: Doc2

We can try to unify such APIs that differ in julia and python(like name of function arguments, position of parameters, etc.) which will help the users in migrating from one language to the other easily.

Some of the APIs are:

@jstac
Copy link
Contributor

jstac commented Dec 6, 2022

Yes, that would be great @Smit-create . The tauchen one has always bothered me. This one might need unifying as well:

http://quantecon.github.io/QuantEcon.jl/latest/api/QuantEcon.html#QuantEcon.rouwenhorst

The only issue is that these are breaking changes, so we would need to coordinate changes on the lectures and any other downstream code (e.g., the DP textbook).

@oyamad
Copy link
Member

oyamad commented Dec 6, 2022

See also #363.

@Smit-create
Copy link
Member Author

Thanks, @jstac and @oyamad. I have opened a PR to fix the same. Once that is merged in the master, I will then fix the lectures/dp_textbook code.

@jstac
Copy link
Contributor

jstac commented Dec 6, 2022

Thanks @Smit-create . The relevant PR is #664 . Is the idea to shift all Python to Julia equivalent?

@mmcky We will have to be careful with this issue since a number of the QE lectures use tauchen and perhaps rouwenhorst.

@oyamad oyamad added the breaking label Dec 7, 2022
@Smit-create
Copy link
Member Author

Smit-create commented Dec 13, 2022

Another difference:
Python: markov_chain_object.P
Julia: markov_chain_object.p

@marcdelabarrera
Copy link

Can you make the UserWarning to appear only once per session?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants