Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly behaves slightly differently #5

Closed
skjnldsv opened this issue Nov 17, 2020 · 4 comments · May be fixed by #6
Closed

Nightly behaves slightly differently #5

skjnldsv opened this issue Nov 17, 2020 · 4 comments · May be fixed by #6

Comments

@skjnldsv
Copy link 

        env:
          app_name: ${{ env.APP_NAME }}
          appstore_token: ${{ secrets.APPSTORE_TOKEN }}
          download_url: ${{ steps.attach_to_release.outputs.browser_download_url }}
          app_private_key: ${{ secrets.APP_PRIVATE_KEY }}
          nightly: ${{ github.event.release.prerelease }}

So if you upload a beta, your release must be named v10.0.0-rc.2 or v10.0.0-beta.1
https://github.com/nextcloud/forms/releases/tag/v2.0.0-beta.4
https://github.com/nextcloud/forms/releases/tag/v2.0.0-rc.1

But they must be published as regular releases on the appstore. They will be detected as beta/rc automatically and sent to the appropriate channels only
It's a bit weird, but 🤷

https://apps.nextcloud.com/apps/spreed/releases?platform=20#20
Capture d’écran_2020-11-17_08-15-30

cc @nickvergessen for confirmation
@nickvergessen
Copy link

Yeah the nightly flag is for daily builds basically.

@R0Wi
Copy link
Owner

R0Wi commented Nov 17, 2020

I see then i missunderstood this flag :-) Then for the daily builds (let's say master) we would just set the flag to true otherwise (like when creating the artifact via creating a new release on Github) we'd set it false, right?

@nickvergessen
Copy link

yes

@R0Wi R0Wi linked a pull request Nov 17, 2020 that will close this issue
Fix docs#5 #6
Open
@R0Wi
Copy link
Owner

R0Wi commented Nov 17, 2020

@nickvergessen @skjnldsv please have a look at #6 if this suits your needs :-)

@R0Wi R0Wi closed this as completed Aug 14, 2021
@skjnldsv skjnldsv mentioned this issue Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docs#5 R0Wi/nextcloud-appstore-push-action
3 participants
@nickvergessen @skjnldsv @R0Wi