Skip to content

Latest commit

 

History

History
41 lines (30 loc) · 1.97 KB

pull_request_template.md

File metadata and controls

41 lines (30 loc) · 1.97 KB

Description

Related PRs

Notion Ticket

PR Checklist for reviewer

  • Build it on your own local instance and test new features or changes.
  • Pass UITesting on your local instance on the matching UITesting branch.
  • Pass all jest tests.
    • Update jest test directories in .github/workflows/tests.js.yml to include new tests
  • It is functional and meets the requirements?
  • Are any shorthand variable names are included in the Glossary?
  • Does it include descriptive code comments?
  • Does it follow the Style Guide for any languages included?
  • Is it well-documented?
    • Module-specific README lists out any dependencies
    • Sufficient instructions for setup
    • Links to any relevant LabKey documentation
  • Are any new features tested via UITesting or jest?
  • Does it have any new dependencies? Is it justifiable?
  • Is there code duplication that could be reduced?
  • Are there performance improvements that could be made?