From 5eedeba2fd451d44ab4218b20a4f3cf9f2c85fc4 Mon Sep 17 00:00:00 2001
From: Ties de Kock <ties@tiesdekock.nl>
Date: Tue, 5 Mar 2024 10:14:54 +0100
Subject: [PATCH 1/4] use rpki-commons 1.39.1

---
 build.gradle                           | 2 +-
 src/main/java/net/ripe/rpki/ta/TA.java | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/build.gradle b/build.gradle
index 76ad408..f9634ef 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,7 +35,7 @@ version = ENV['RELEASE_VERSION'] ?: gitRef()
 description = 'RIPE NCC Trust Anchor'
 
 dependencies {
-    implementation 'net.ripe.rpki:rpki-commons:1.35'
+    implementation 'net.ripe.rpki:rpki-commons:1.39.1'
     implementation 'commons-cli:commons-cli:1.6.0'
     implementation 'org.slf4j:slf4j-api:2.0.7'
     runtimeOnly 'org.slf4j:slf4j-simple:2.0.7'
diff --git a/src/main/java/net/ripe/rpki/ta/TA.java b/src/main/java/net/ripe/rpki/ta/TA.java
index 9452a0c..9a2e1f6 100644
--- a/src/main/java/net/ripe/rpki/ta/TA.java
+++ b/src/main/java/net/ripe/rpki/ta/TA.java
@@ -454,8 +454,7 @@ private X509Crl createNewCrl(final SignCtx signCtx) {
                 .withAuthorityKeyIdentifier(signCtx.keyPair.getPublic())
                 .withNumber(nextCrlNumber(signCtx.taState))
                 .withIssuerDN(issuer)
-                .withThisUpdateTime(validityPeriod.getNotValidBefore())
-                .withNextUpdateTime(validityPeriod.getNotValidAfter())
+                .withValidityPeriod(validityPeriod)
                 .withSignatureProvider(getSignatureProvider());
         fillRevokedObjects(builder, signCtx.taState.getSignedProductionCertificates());
         fillRevokedObjects(builder, signCtx.taState.getPreviousTaCertificates());
@@ -548,8 +547,7 @@ private ManifestCmsBuilder createBasicManifestBuilder(X509ResourceCertificate ee
         ValidityPeriod validityPeriod = validityPeriods.manifest();
         return new ManifestCmsBuilder().
                 withCertificate(eeCertificate)
-                .withThisUpdateTime(validityPeriod.getNotValidBefore())
-                .withNextUpdateTime(validityPeriod.getNotValidAfter())
+                .withValidityPeriod(validityPeriod)
                 .withManifestNumber(nextManifestNumber(signCtx.taState))
                 .withSignatureProvider(getSignatureProvider());
     }

From 9ed7f4ec37395caeaaf97598f6610cb5a95d07c6 Mon Sep 17 00:00:00 2001
From: Ties de Kock <ties@tiesdekock.nl>
Date: Mon, 15 Apr 2024 09:36:11 +0200
Subject: [PATCH 2/4] Update changelog

---
 README.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/README.md b/README.md
index 496e9f7..9e0b7d6 100644
--- a/README.md
+++ b/README.md
@@ -16,6 +16,7 @@ Changelog
 ---------
 
 ### main
+  * rpki-commons 1.39.1
 
 ### v0.4.0
   * **hotfix** fix bug in manifest this/nextUpdate calculation

From eb8fc1a2ae13ebbed061265c47286cc0ce9ba85e Mon Sep 17 00:00:00 2001
From: Ties de Kock <ties@tiesdekock.nl>
Date: Mon, 15 Apr 2024 09:44:43 +0200
Subject: [PATCH 3/4] Update gradle plugins

---
 build.gradle | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/build.gradle b/build.gradle
index f9634ef..5d685db 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,9 +1,9 @@
 plugins {
     id 'application'
     id 'jacoco'
-    id 'io.freefair.lombok' version '8.1.0'
-    id 'org.sonarqube' version '3.5.0.2730'
-    id 'com.google.cloud.tools.jib' version '3.3.2'
+    id 'io.freefair.lombok' version '8.6'
+    id 'org.sonarqube' version '5.0.0.4638'
+    id 'com.google.cloud.tools.jib' version '3.4.2'
 }
 
 repositories {

From d99dec2c1da9500905903a3a19b24d51b57e70b6 Mon Sep 17 00:00:00 2001
From: Ties de Kock <ties@tiesdekock.nl>
Date: Mon, 15 Apr 2024 09:45:47 +0200
Subject: [PATCH 4/4] Update gradle version in wrapper

---
 README.md                                | 2 ++
 gradle/wrapper/gradle-wrapper.properties | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 9e0b7d6..1d26f19 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,8 @@ Changelog
 
 ### main
   * rpki-commons 1.39.1
+  * Updated gradle plugins (to fix build warnings)
+  * Updated gradle version in gradle wrapper
 
 ### v0.4.0
   * **hotfix** fix bug in manifest this/nextUpdate calculation
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
index 9f4197d..b82aa23 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME