Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When would you support USE_FLASH_ATTENTION compile? #1252

Closed
xbcReal opened this issue Jul 7, 2023 · 1 comment
Closed

When would you support USE_FLASH_ATTENTION compile? #1252

xbcReal opened this issue Jul 7, 2023 · 1 comment

Comments

@xbcReal
Copy link

xbcReal commented Jul 7, 2023

🚀 The feature, motivation and pitch

Hi, I wanna a faster transformer implemention in pytorch, and I found one in pytorch code ,whose path is pytorch/aten/src/Aten/native/transformers/cuda/, and it needs support USE_FLASH_ATTENTION compile. Furtherly I found some asm ptx code in utils.h, and amd-pytorch doesn't support it until now. So do you have any plan to support this feature?

@xbcReal xbcReal changed the title when would you support USE_FLASH_ATTENTION compile? When would you support USE_FLASH_ATTENTION compile? Jul 7, 2023
@darren-amd
Copy link

Hi @xbcReal,

This is supported now; support was added through the upstream issue: pytorch#112997. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants