WIP: core/IFuseFeeDistributor interface is currently incomplete #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Jun 7, 2022
|
|
||
| function renounceOwnership() external; | ||
|
|
||
| function transferOwnership(address newOwner) external; | ||
|
|
||
| function() external payable; |
There was a problem hiding this comment.
It is not exactly clear to me why this would need to be part of the interface (line 162) but I left it in for now
zerosnacks
commented
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor issue but it fixes the incompleteness of the interface.
Closes: #9
Updates
core/IFuseFeeDistributorinterface as it is currently incomplete.The interface generator automatically uses
memoryinstead ofcalldataupon constructing the interface which is incorrect.Perhaps there is a way of adding that information to the generated ABI so that the interfaces can be reconstructed correctly.