New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 Critical underflow #114

Open

transmissions11 opened this issue Mar 4, 2022 · 1 comment

Contributor

transmissions11 commented Mar 4, 2022

major underflow here, cannot do in unchecked.

vaults/src/Vault.sol

Line 372 in 2edd5eb

totalUnderlyingHeld = totalStrategyHoldings - lockedProfit();

Contributor Author

transmissions11 commented Mar 4, 2022

maybe could do the subtraction of locked profit from totalStrategyHoldings + totalFloat unchecked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment