Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly imports constants as functions #27

Open
0x-r4bbit opened this issue May 1, 2018 · 3 comments
Open

Incorrectly imports constants as functions #27

0x-r4bbit opened this issue May 1, 2018 · 3 comments
Assignees

Comments

@0x-r4bbit
Copy link

Before

import { never } from 'rxjs/observable/never

After

import { NEVER as never } from 'rxjs';

^ This shouldn't be.

@benlesh
Copy link
Member

benlesh commented May 1, 2018

this should be:

import { NEVER } from rxjs'``

and then usage is just:

NEVER (not never() or NEVER())

@mgechev
Copy link
Collaborator

mgechev commented May 2, 2018

This will require the development of a new rule in order to be properly solved. Not sure if I'll be able to work on this in the next a couple of weeks.

@cartant
Copy link

cartant commented May 9, 2018

Something to watch out for is that empty can be passed a scheduler argument, so simply replacing the call with the constant could change behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants