Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nametag Dupe #53

Open
EtherealMC-Bit opened this issue Jul 24, 2024 · 0 comments
Open

Nametag Dupe #53

EtherealMC-Bit opened this issue Jul 24, 2024 · 0 comments

Comments

@EtherealMC-Bit
Copy link

Describe the bug
When someone uses a nametag on a Villager but the item use event is cancelled because they don't have permission, the plugin will give them an extra nametag as if they had used the nametag on the villager. In my server this is because of Towny not allowing outsiders to nametag villagers in towns that aren't theirs.

Server Info
git-Paper-454 (MC: 1.20.4)

Type of Server Software (Ex. Paper):
To Reproduce
Steps to reproduce the behavior:

  1. Go to a town where you don't have destroy permissions (https://github.com/TownyAdvanced/Towny/wiki/How-Towny-Works#towny-plot-perms)
  2. Use a nametag on a villager in the town
  3. The nametag will be duplicated.

But I think this happens whenever the event for nametagging a villager is cancelled, because the plugin doesn't check for this possibility.

Expected behavior
The nametag should not be duplicated.

let me know if you need any other info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant