Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with “Add Peer” functionality when using a Tor Lightning URL #1478

Open
thusspokedata opened this issue Dec 11, 2024 · 0 comments
Open

Comments

@thusspokedata
Copy link

Describe the bug
In the Peers/Channels section, under Peers, when clicking “Add Peer” and entering a Tor Lightning URL, the interface accepts the input but then randomly selects one of the already connected peers instead of adding the new peer. If the user proceeds without noticing this, it can lead to opening a channel with an unintended peer.

To Reproduce
Steps to reproduce the behavior:
1. Go to the Peers/Channels section and click on Peers.
2. Click “Add Peer” and enter a Tor Lightning URL.
3. Observe that the Lightning URL is accepted, but the interface randomly selects an already connected peer.
4. Proceed to open a channel and notice that the channel is opened with the incorrect peer.

Screenshots
For security and privacy reasons, I have not included any screenshots.

Your environment

  • Version of RTL: Version 0.15.4-beta
  • Version of Lightning Node: Version 0.18.3-beta
  • Version of btcd, bitcoind, or other backend: Bitcoin Core version 28.0
  • Browser & browser version: Firefox 133.0
  • Operating system (uname -a on *Nix): Linux umbrel 6.6.31+rpt-rpi-v8 Create LICENSE #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/Linux
  • any other relevant environment details: My Umbrel version is still 1.2.2.

Additional context
This behavior is particularly problematic because it gives the user the impression that the entered peer was added successfully. If the user does not carefully verify the peer before proceeding, they might inadvertently open a channel with a peer they did not intend to connect with (as happened to me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant