Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to error screen on cln connection error #1457

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Nov 6, 2024

Fixes #1456

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a currency conversion component that allows users to convert between BTC, SATS, and other currencies.
    • Added a transaction reporting table that supports filtering and sorting of transaction records.
  • Bug Fixes

    • Updated error handling in the application to provide clearer feedback and redirect users to an error page when encountering service issues.
  • Documentation

    • Enhanced licensing information for various Angular packages and libraries.
  • Chores

    • Removed outdated JavaScript files and replaced them with updated versions to improve performance and maintainability.

@ShahanaFarooqui ShahanaFarooqui added bug Something isn't working Core Lightning labels Nov 6, 2024
@ShahanaFarooqui ShahanaFarooqui added this to the 0.15.3 milestone Nov 6, 2024
Copy link

coderabbitai bot commented Nov 6, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on modifications to URL endpoints, enhancements to configuration management, and the introduction of new Angular components for currency conversion and transaction reporting. Key updates include altering the casing of the disableOffer endpoint, updating method signatures in the CommonService and ConfigService classes to accept configuration parameters, and adding new components for handling currency transactions in the frontend. Additionally, licensing information for various packages has been updated, and several obsolete files have been removed.

Changes

File Change Summary
backend/controllers/cln/offers.js Updated disableOffer endpoint URL from /v1/disableOffer to /v1/disableoffer.
server/controllers/cln/offers.ts Updated disableOffer endpoint URL from /v1/disableOffer to /v1/disableoffer.
backend/utils/common.js Modified readCookie method to accept a config parameter.
server/utils/common.ts Modified readCookie method to accept a config parameter.
backend/utils/config.js Updated setSSOParams to pass config to readCookie, renamed properties in updateConfig.
server/utils/config.ts Updated setSSOParams to pass config to readCookie, renamed properties in updateConfig.
frontend/193.0e1a81316bbc29da.js Added new Angular components for currency conversion and transaction reporting.
frontend/193.b1206fbf24aa1327.js Removed obsolete currency converter component.
frontend/3rdpartylicenses.txt Added and updated licensing information for various Angular packages.
frontend/index.html Updated script source file names for JavaScript modules.
frontend/polyfills.277648f7b3e820e3.js Removed obsolete polyfills file.
frontend/polyfills.2fc68655e9a361e8.js Introduced new polyfills file for Node.js-like buffer functionalities.
frontend/runtime.738cba8440999ebd.js Removed obsolete runtime file.
frontend/runtime.fccd4ea409502489.js Introduced new runtime file with enhanced module loading system.
src/app/cln/store/cln.effects.ts Modified error handling in infoFetchCL effect to redirect to an error page on service unavailable errors.

Assessment against linked issues

Objective Addressed Explanation
Login screen does not navigate to error screen if connection was refused by the node (#1456)

Possibly related PRs

Poem

🐰 In the code, a change we see,
Offers now disable with glee!
New components for currency's dance,
Enhancing the app with every chance.
With licenses clear and paths so bright,
Our code hops forward, a joyful sight!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ShahanaFarooqui ShahanaFarooqui changed the base branch from master to Release-0.15.3 November 6, 2024 20:26
@ShahanaFarooqui ShahanaFarooqui merged commit 14c864f into Release-0.15.3 Nov 6, 2024
1 check was pending
ShahanaFarooqui added a commit that referenced this pull request Nov 11, 2024
* Fix `Unknown command` error when disabling offers on CLN. ([#1443]) (#1451)
* Add missing SSO options to config (#1455)
* Fix for cln logic screen navigation (#1457)
* Transactions destination address display fix (#1458)
* cln delexpiredinvoices deprecation fix (#1459)
* Read LN_IMPLEMENTATION from environment (#1460)
* Add Fee Rate Information on Send Funds Modal (#1461)
* Artifact script fix (#1464)
* Add AMP toggle for LND Send Payments (#1466)

---------

Co-authored-by: Se7enZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Lightning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login screen does not navigate to error screen if connection was refused by the node
1 participant