Fix URI template rendering #4
Comments
Robsteranium
added a commit
that referenced
this issue
Nov 8, 2021
The URI template spec supports [fragment identifiers](https://datatracker.ietf.org/doc/html/rfc6570#section-3.2.4) by expanding a template like `{#var}`. Glue interprets the hash char as a comment as it's inside curly braces. [A recent change to glue](tidyverse/glue#224) flushed this out. This patch rewrites the template as `#{var}`. This has the desired effect when the value is present but doesn't conform with the spec properly as the whole fragment (including the `#`) should be omitted. This is raised in #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Templates with
{#var}are rewritten as#{var}, this doesn't comply with the spec for fragment expansion if the var is undefined.Templates with an absolute URL e.g.
http://example.org/countries.csv{#countryCode}have{+url}prepended erroneously (see e.g. "manifest-validation#test030").The text was updated successfully, but these errors were encountered: