Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Deletion #171

Open
Rekonin opened this issue Oct 21, 2024 · 2 comments
Open

File Deletion #171

Rekonin opened this issue Oct 21, 2024 · 2 comments

Comments

@Rekonin
Copy link

Rekonin commented Oct 21, 2024

When selecting delete, the software does not prompt to ask if you're sure, and the file is just gone.
Bypasses recycle bin entirely.
That's absolutely insane.

@phamduylong
Copy link
Contributor

@Ruben2776 mind if I give this a try? Probably a prompt-style MessageBox is sufficient.

@Ruben2776
Copy link
Owner

Ruben2776 commented Nov 15, 2024

Currently, the issue of not using the recycle bin was unfortunately a mistake of passing the wrong boolean parameter to the file deletion function. This has already been fixed, and will be in the next release.

@phamduylong Thanks for the offer. You may give try it. Currently, I'm in the midst of rewriting the project for the Avalonia UI platform, so either it would have to be done twice or only for the upcoming Avalonia versions.

If you'd want to, for the WPF version, a regular MessageBox would be fine. However, for Avalonia, I'd want my own pop-up message style functions, similar to how SukiUI does it, but with my own theming and styling.

Additionally, there'd need to be translations added for all of them. Just adding English translation is fine, and I can add the rest of them.

Edit: The confirmation dialog should only be shown on permanent file deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants