Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove this sed? #48

Open
o-liver opened this issue Nov 13, 2023 · 2 comments
Open

Can we remove this sed? #48

o-liver opened this issue Nov 13, 2023 · 2 comments

Comments

@o-liver
Copy link
Member

o-liver commented Nov 13, 2023

It we have the following, here in the dockerfile:

# Workaround for https://npm.sap.com issue with open SSL in Debian Buster
RUN CIPHERS="$(openssl ciphers)" && sed -i "s/DEFAULT@SECLEVEL=2/$CIPHERS:DH-RSA-AES256-SHA256/g" /etc/ssl/openssl.cnf

Now we do not user npm.sap.com anymore and buster is also about to be removed. Can we remove this sed?

@fwilhe Could you comment? Do you have any memory of this?

@o-liver
Copy link
Member Author

o-liver commented Nov 13, 2023

@fwilhe
Copy link
Contributor

fwilhe commented Aug 23, 2024

@o-liver Sorry, just saw this now. Sure this can be removed. Just seen you've updated the image to bookworm, and as npm.sap.com is not operational anymore there is no reason to keep this line.

fwilhe added a commit that referenced this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants