Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit breaks test for ftolerance #23

Open
freifrauvonbleifrei opened this issue Oct 5, 2022 · 1 comment
Open

Commit breaks test for ftolerance #23

freifrauvonbleifrei opened this issue Oct 5, 2022 · 1 comment

Comments

@freifrauvonbleifrei
Copy link
Contributor

... although it really should not!

After this commit here
fca872c
the ftolerance tests somehow suddenly end before the RUN_FIRST signal is finished.

However, the commit only adds a runtime error in DFG, a function in test_helper and calls to that function in some tests. Not the ftolerance test.

To really show this, I have added an error to the test

BOOST_TEST_ERROR("worker never cleanly exits! " + std::to_string(signal));

which is never thrown!

@freifrauvonbleifrei
Copy link
Contributor Author

freifrauvonbleifrei added a commit that referenced this issue Oct 28, 2022
(cf. #23)

(cherry picked from commit 9251b7f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant