Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Replace AtomPopover cloneElement by PrimitiveInjector #2328

Closed
andresin87 opened this issue Sep 26, 2022 · 2 comments · Fixed by #2406
Closed

✨Replace AtomPopover cloneElement by PrimitiveInjector #2328

andresin87 opened this issue Sep 26, 2022 · 2 comments · Fixed by #2406
Assignees
@andresin87
Labels
hacktoberfest refactor code refactor

Comments

@andresin87
Copy link
Member

andresin87 commented Sep 26, 2022 •
edited
Loading

Is your iteration request related to a problem?

No response

Describe the solution you'd like

In the PopoverExtendChildren class
Wrap the TooltipExtendChildren children in an @s-ui/primitiveInjector with the proper props: onClick and className and also the ref

Screenshots

No response

Additional context**

No response

Additional info

take a look on #2317
@andresin87 andresin87 added the refactor code refactor label Sep 26, 2022
@andresin87 andresin87 changed the title ✨✨Replace AtomPopover cloneElement by PrimitiveInjector ✨Replace AtomPopover cloneElement by PrimitiveInjector Sep 27, 2022
@meerhamzadev
Copy link

meerhamzadev commented Oct 4, 2022 •
edited
Loading

Hey, I'm interested in this issue. Can you explain this issue a little more? and also can you spot the file where we are supposed to do refactor.

This was linked to pull requests Oct 18, 2022
feat(atom/input): refactor #2310
Open
refactor(components/atom/popover): lint #2406
Merged
This was unlinked from pull requests Oct 18, 2022
feat(atom/input): refactor #2310
Open
refactor(components/atom/popover): lint #2406
Merged
@andresin87 andresin87 linked a pull request Oct 18, 2022 that will close this issue
refactor(components/atom/popover): lint #2406
Merged
8 tasks
Repository owner moved this from Todo to Done in Hacktoberfest 2022 🎉 Oct 18, 2022
@andresin87 andresin87 self-assigned this Oct 18, 2022
@andresin87
Copy link
Member Author

@meerhamzadev sorry. maybe #2403 is an easier one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andresin87 andresin87

Labels
hacktoberfest refactor code refactor
Projects
No open projects
Hacktoberfest 2022 🎉
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(components/atom/popover): lint SUI-Components/sui-components
2 participants
@andresin87 @meerhamzadev