-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/scmi 124851 [Domain models initiative] validate method rules #1788
Open
aleixadevinta
wants to merge
5
commits into
master
Choose a base branch
from
feat/SCMI-124851_validate_method_rules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleixadevinta
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
July 19, 2024 08:51
aleixadevinta
changed the title
[Domain models iniciative] Feat/scmi 124851 validate method rules
Feat/scmi 124851 [Domain models iniciative] validate method rules
Jul 19, 2024
aleixadevinta
changed the title
Feat/scmi 124851 [Domain models iniciative] validate method rules
Feat/scmi 124851 [Domain models initiative] validate method rules
Jul 24, 2024
oriolpuig
reviewed
Jul 24, 2024
const filePath = context.getFilename() | ||
const relativePath = path.relative(context.getCwd(), filePath) | ||
|
||
// Check if the file is inside requierd folders (useCases, services, repositories, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this comment or remove it 👀
oriolpuig
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
kikoruiz
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request we ensure that a doamin model class (value object or entity) has a static
validate
method.Related Issue
SCMI-124851