Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symbolic files of size 0 #46

Open
moralismercatus opened this issue Jun 1, 2018 · 0 comments
Open

Allow symbolic files of size 0 #46

moralismercatus opened this issue Jun 1, 2018 · 0 comments

Comments

@moralismercatus
Copy link
Collaborator

@likebreath @UnseeingEye

Currently, when a file of size 0 is listed as a symbolic input file, CRETE raises an assertion. Presumably, the reasoning was that the user likely made a mistake.

However, there is nothing in the file system against files of size 0, and it would make CRETE consistent with the FS.

In our particular case, this restriction caused problems with our infrastructure which was automatically generating files.

As a mitigation, I changed the assertion to treat symbolic files of size 0 to concrete:

https://github.com/moralismercatus/crete-dev/blob/exciting/lib/include/crete/harness_config.h#L617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant