Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

feat: correct origins for CombinedCallGraphNodes #269

Merged
merged 22 commits into from
Jun 18, 2024

Conversation

lukarade
Copy link
Contributor

@lukarade lukarade commented May 4, 2024

Closes #267

Summary of Changes

@lukarade lukarade linked an issue May 4, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented May 4, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 12 0 0 1.81s
✅ PYTHON mypy 12 0 3.76s
✅ PYTHON ruff 12 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 89.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (492134e) to head (1737a01).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...er/processing/api/purity_analysis/model/_purity.py 84.78% 7 Missing ⚠️
...cessing/api/purity_analysis/_resolve_references.py 85.00% 3 Missing ⚠️
...er/processing/api/purity_analysis/_infer_purity.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   92.94%   92.87%   -0.07%     
==========================================
  Files          98       98              
  Lines        6818     6853      +35     
==========================================
+ Hits         6337     6365      +28     
- Misses        481      488       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review June 17, 2024 15:06
@lars-reimann lars-reimann requested a review from a team as a code owner June 17, 2024 15:06
@lars-reimann
Copy link
Member

@lukarade I'll review after the conflicts are resolved.

…allgraphnodes

# Conflicts:
#	tests/library_analyzer/processing/api/purity_analysis/test_infer_purity.py
@lukarade
Copy link
Contributor Author

@lukarade I'll review after the conflicts are resolved.

@lars-reimann Done.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just a few requests regarding types in the documentation.

@lukarade
Copy link
Contributor Author

Very nice, just a few requests regarding types in the documentation.

Since we talked about that on multiple occasions before, and for consistency, all type hints from docstrings were removed.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks.

@lars-reimann lars-reimann merged commit 07304da into main Jun 18, 2024
6 of 8 checks passed
@lars-reimann lars-reimann deleted the 267-correct-origins-for-combinedcallgraphnodes branch June 18, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct origins for CombinedCallGraphNodes
3 participants