-
Notifications
You must be signed in to change notification settings - Fork 0
feat: correct origins for CombinedCallGraphNodes
#269
feat: correct origins for CombinedCallGraphNodes
#269
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 92.94% 92.87% -0.07%
==========================================
Files 98 98
Lines 6818 6853 +35
==========================================
+ Hits 6337 6365 +28
- Misses 481 488 +7 ☔ View full report in Codecov by Sentry. |
…nce-variables' into 267-correct-origins-for-combinedcallgraphnodes
@lukarade I'll review after the conflicts are resolved. |
…allgraphnodes # Conflicts: # tests/library_analyzer/processing/api/purity_analysis/test_infer_purity.py
@lars-reimann Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, just a few requests regarding types in the documentation.
src/library_analyzer/processing/api/purity_analysis/model/_purity.py
Outdated
Show resolved
Hide resolved
src/library_analyzer/processing/api/purity_analysis/model/_purity.py
Outdated
Show resolved
Hide resolved
src/library_analyzer/processing/api/purity_analysis/_build_call_graph.py
Outdated
Show resolved
Hide resolved
src/library_analyzer/processing/api/purity_analysis/_build_call_graph.py
Outdated
Show resolved
Hide resolved
src/library_analyzer/processing/api/purity_analysis/model/_purity.py
Outdated
Show resolved
Hide resolved
src/library_analyzer/processing/api/purity_analysis/model/_purity.py
Outdated
Show resolved
Hide resolved
Since we talked about that on multiple occasions before, and for consistency, all type hints from docstrings were removed. |
src/library_analyzer/processing/api/purity_analysis/_resolve_references.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, thanks.
Closes #267
Summary of Changes