Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

feat: detect instance variables generated with @property-functions #281

Merged

Conversation

lukarade
Copy link
Contributor

@lukarade lukarade commented Jun 5, 2024

Closes #272

Summary of Changes

Added the detection of instance variables generated with @property-functions.

@lukarade lukarade added the purity Inferring the purity of functions label Jun 5, 2024
@lukarade lukarade self-assigned this Jun 5, 2024
@lukarade lukarade linked an issue Jun 5, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jun 5, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 1.89s
✅ PYTHON mypy 5 0 3.21s
✅ PYTHON ruff 5 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lukarade lukarade marked this pull request as ready for review June 5, 2024 21:17
@lukarade lukarade requested a review from a team as a code owner June 5, 2024 21:17
@lars-reimann lars-reimann merged commit 492134e into main Jun 18, 2024
7 of 8 checks passed
@lars-reimann lars-reimann deleted the 272-missing-detection-of-properties-as-instance-variables branch June 18, 2024 14:12
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (c451179) to head (4270093).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   92.98%   92.94%   -0.04%     
==========================================
  Files          98       98              
  Lines        6813     6818       +5     
==========================================
+ Hits         6335     6337       +2     
- Misses        478      481       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
purity Inferring the purity of functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing detection of @properties as instance variables
3 participants