Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to luarocks with automated semver versioning/releases #217

Open
simifalaye opened this issue Oct 30, 2024 · 5 comments · May be fixed by #356
Open

Publish to luarocks with automated semver versioning/releases #217

simifalaye opened this issue Oct 30, 2024 · 5 comments · May be fixed by #356
Labels
backlog Likely not getting to it anytime soon feature New feature or request fuzzy Filtering and sorting of completion items

Comments

@simifalaye
Copy link

I believe this repo would benefit from publishing to luarocks for rocks.nvim and lazy.nvim users. On top of the reasons provided in the rocks.nvim and the nvim-best-practices repos, another reason is that this plugin produces/deploys a binary that needs to be available on a user's machine so deploying that to luarocks would simplify that deployment since both rocks.nvim and lazy.nvim support the use of a rockspec.

See this repo for detailed instructions: https://github.com/nvim-neorocks/sample-luarocks-plugin
@Saghen
Copy link
Owner

Saghen commented Oct 30, 2024 •
edited
Loading

Is this something you'd be interested in taking on? I'm open to using luarocks as long as we can ship the binaries for all supported platforms (linux musl, linux glibc, mac, windows msvc). I have my hands full with some bigger upcoming changes but I'd like to get this sorted before 1.0.

I believe you're already aware of this, but for others, @benlubas provided a reference impl here: b9a195b (#105)

@simifalaye
Copy link
Author

Potentially. @mrcjkb, would you be interested as I'm sure it would take you much less time to get it set up since you'd done it for a bunch of plugins already?

@mrcjkb
Copy link

mrcjkb commented Oct 30, 2024

I'm busy this weekend, but might be able to find some time to look into it soon after 😄

@Saghen Saghen added feature New feature or request fuzzy Filtering and sorting of completion items backlog Likely not getting to it anytime soon labels Oct 31, 2024
@mrcjkb mrcjkb mentioned this issue Nov 5, 2024
Merged
13 tasks
@simifalaye
Copy link
Author

@mrcjkb have you had some time to look at this yet?

@mrcjkb
Copy link

mrcjkb commented Nov 20, 2024

not yet I'm afraid. Been too focused on rocks development 😅

@mrcjkb mrcjkb linked a pull request Nov 21, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Likely not getting to it anytime soon feature New feature or request fuzzy Filtering and sorting of completion items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: package for luarocks mrcjkb/blink.cmp
3 participants
@Saghen @mrcjkb @simifalaye