Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl likely does not overwrite #488

Closed
z3z1ma opened this issue Dec 10, 2024 · 1 comment
Closed

Curl likely does not overwrite #488

z3z1ma opened this issue Dec 10, 2024 · 1 comment

Comments

@z3z1ma
Copy link

z3z1ma commented Dec 10, 2024

'curl',
'--fail', -- Fail on 4xx/5xx
'--location', -- Follow redirects
'--silent', -- Don't show progress
'--show-error', -- Show errors, even though we're using --silent
'--create-dirs',
'--output',
download.lib_path,
url,

I am fairly certain that curl requires the --clobber option explicitly passed to be able to overwrite a file if it exists.

Noting this here in case the issue of updating blink resulting in neovim crashing due to the file download failing is hitting this codepath. Such as in:

#115
#68

@Saghen
Copy link
Owner

Saghen commented Dec 10, 2024

It looks like curl 8.11.0 will overwrite without asking for permission, tested with curl --output test https://example.com. If curl was failing, it should get caught by the .code ~= 0 check. Thanks for looking into this though, I'm still stumped on it :/

@Saghen Saghen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants