Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Docker Compose Configuration by Using .env File #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Secure Docker Compose Configuration by Using .env File #80

wants to merge 1 commit into from

Conversation

AtulRajput01
Copy link

Secure Docker Compose Configuration by Using .env File:

This PR addresses the issue #79

Changes Made:

  1. docker-compose.yml : Removed the direct inclusion of POSTGRES_USER and POSTGRES_PASSWORD environment variables and replaced them with references to the .env.sample file.
  2. Added .env.sample file containing the POSTGRES_USER and POSTGRES_PASSWORD environment variables as placeholders.

jayanth-kumar-morem
jayanth-kumar-morem requested changes Jun 19, 2023
View reviewed changes
.env.sample Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jayanth-kumar-morem
jayanth-kumar-morem requested changes Jun 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jayanth-kumar-morem
jayanth-kumar-morem requested changes Jun 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jayanth-kumar-morem
jayanth-kumar-morem reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@jayanth-kumar-morem jayanth-kumar-morem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see .env not added to .gitignore file.

@AtulRajput01
Copy link
Author

I still see .env not added to .gitignore file.

@jayanth-kumar-morem i added .env file to .gitignore file

jayanth-kumar-morem
jayanth-kumar-morem requested changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@jayanth-kumar-morem jayanth-kumar-morem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on latest changes properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayanth-kumar-morem jayanth-kumar-morem Awaiting requested review from jayanth-kumar-morem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtulRajput01 @jayanth-kumar-morem