Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using open-uri #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −1
Open

stop using open-uri #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/daru/io/importers/csv.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,22 @@ def initialize
# instance = Daru::IO::Importers::CSV.read("matrix_test.csv.gz")
def read(path)
@path = path
@file_data = open(@path)
@file_data = open_data_source(@path)
self
end

private def open_data_source(name)
if name.respond_to?(:open)
name.open
elsif name.respond_to?(:to_str) &&
%r{\A[A-Za-z][A-Za-z0-9+\-\.]*://} =~ name &&
(uri = URI.parse(name)).respond_to?(:open)
uri.open
else
File.open name
end
end

# Imports a `Daru::DataFrame` from a CSV Importer instance
#
# @param headers [Boolean] If this option is `true`, only those columns
Expand Down