Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop offences #74

Closed
wants to merge 6 commits into from
Closed

Fix rubocop offences #74

wants to merge 6 commits into from

Commits on Mar 13, 2018

  1. fix style/ExpandPathArguments

    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    1b79ef8 View commit details
    Browse the repository at this point in the history

  2. fix Security/Open

    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    be4d2aa View commit details
    Browse the repository at this point in the history

  3. add 'db' to white list

    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    6d7214e View commit details
    Browse the repository at this point in the history

  4. fix Naming/UncommunicativeMethodParamName 

    replace `s` to `str`, and add `str` to white list.
    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    0cfc35c View commit details
    Browse the repository at this point in the history

  5. disable Naming/MemoizedInstanceVariableName 

    `@col_offset` isn't memoized instance variable
    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    b705e9b View commit details
    Browse the repository at this point in the history

  6. revert File.open 

    json expect url open.
    @takkanm
    takkanm committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    a8b355d View commit details
    Browse the repository at this point in the history