Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release because of CVE-2019-11358 #63

Open
JeroenKnoops opened this issue May 3, 2019 · 1 comment
Open

New release because of CVE-2019-11358 #63

JeroenKnoops opened this issue May 3, 2019 · 1 comment

Comments

@JeroenKnoops
Copy link

This CVE: https://nvd.nist.gov/vuln/detail/CVE-2019-11358 resulted in some security alerts in projects which use semantic-ui-css

Screenshot 2019-05-03 at 09 44 00

This is caused by the jquery dependency.

Unfortunately you cannot easily update the depencendies because the dependency is to version x.*

  "dependencies": {
    "jquery": "x.*"
  }

I had to update the yarn.lock files manually in several packages to update this dependency. (see Charterhouse/hush-hush@d742661 )

Can you make a new minor release (even without changes) so people can fix the problem by running: yarn upgrade-interactive?

@alyssaruth
Copy link

Because they're specifying x.*, this doesn't actually require another release.

With npm, I've found that the following works:

  • Remove semantic-ui-css from package.json
  • npm install
  • Add semantic-ui-css back
  • npm install

Doesn't require any manual fiddling with package-lock.json or deleting node_modules. Hopefully a similar approach will work for folks on Yarn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants