-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton: add getSeoMeta #2464
Merged
Merged
Skeleton: add getSeoMeta #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
scottdixon
force-pushed
the
sd-skeleton-get-seo-meta
branch
from
August 27, 2024 04:08
d0f3b30
to
29fc315
Compare
wizardlyhel
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this change
scottdixon
force-pushed
the
sd-skeleton-get-seo-meta
branch
from
September 4, 2024 05:12
29fc315
to
808fcde
Compare
This comment has been minimized.
This comment has been minimized.
wizardlyhel
approved these changes
Sep 9, 2024
scottdixon
added a commit
that referenced
this pull request
Sep 12, 2024
This reverts commit de8ba2b.
scottdixon
added a commit
that referenced
this pull request
Sep 12, 2024
Merged
scottdixon
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @blittle!
As we've discussed. Let me know what you think!
This follows the demo-store implementation, it's just a touch lighter.
WHY are these changes introduced?
Resolves https://github.com/Shopify/hydrogen-internal/issues/130
Also helps with https://github.com/Shopify/hydrogen-internal/issues/120 by introducing canonical URL link.
WHAT is this pull request doing?
Adds getSeoMeta to Skeleton template pages.
HOW to test your changes?
Browse Skeleton template and check title/meta/link tags.
Checklist