Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton: add getSeoMeta #2464

Merged
merged 12 commits into from
Sep 9, 2024
Merged

Skeleton: add getSeoMeta #2464

merged 12 commits into from
Sep 9, 2024

Conversation

scottdixon
Copy link
Contributor

Hey @blittle!

As we've discussed. Let me know what you think!

This follows the demo-store implementation, it's just a touch lighter.

WHY are these changes introduced?

Resolves https://github.com/Shopify/hydrogen-internal/issues/130

Also helps with https://github.com/Shopify/hydrogen-internal/issues/120 by introducing canonical URL link.

WHAT is this pull request doing?

Adds getSeoMeta to Skeleton template pages.

HOW to test your changes?

Browse Skeleton template and check title/meta/link tags.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Aug 23, 2024

Oxygen deployed a preview of your sd-skeleton-get-seo-meta branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment September 9, 202410:01 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change

This comment has been minimized.

@scottdixon scottdixon merged commit de8ba2b into main Sep 9, 2024
13 checks passed
@scottdixon scottdixon deleted the sd-skeleton-get-seo-meta branch September 9, 2024 22:05
scottdixon added a commit that referenced this pull request Sep 12, 2024
scottdixon added a commit that referenced this pull request Sep 12, 2024
scottdixon added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants