Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): Agent Store V2 #8306

Draft
wants to merge 167 commits into
base: dev
Choose a base branch
from
Draft

feat(platform): Agent Store V2 #8306

wants to merge 167 commits into from
+18,347 −4,993

Conversation

Swiftyos
Copy link
Contributor

@Swiftyos Swiftyos commented Oct 10, 2024 •
edited
Loading

Background

To make life easier when creating our new ui, I'm going to be building up a compent library and making sure they all stay pure react functions.

Changes 🏗️

  • Added Search Bar Component
Screenshot 2024-10-10 at 18 42 56

TODO

  • Filter Chips
    Screenshot 2024-10-11 at 12 32 16

  • Featured Store Card
    Screenshot 2024-10-11 at 12 32 03

  • Creator Card

Screenshot 2024-10-11 at 12 27 24

  • Store Card

Screenshot 2024-10-11 at 12 33 17

  • Button
    Screenshot 2024-10-11 at 12 27 05

  • Callout
    Screenshot 2024-10-11 at 12 26 40

  • NavBar
    Screenshot 2024-10-11 at 12 32 56

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Swiftyos Swiftyos self-assigned this Oct 10, 2024
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Oct 10, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit a53f3f0
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673f27343e07d10008822765

@github-actions github-actions bot added size/xl and removed size/l labels Oct 11, 2024
@Swiftyos Swiftyos marked this pull request as ready for review October 11, 2024 10:56
@Swiftyos Swiftyos requested a review from a team as a code owner October 11, 2024 10:56
@Swiftyos Swiftyos requested review from Torantulino and Bentlybro and removed request for a team October 11, 2024 10:56
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2024
View reviewed changes
autogpt_platform/backend/test/test_data_creator.py

def get_image():
url = faker.image_url()
while "placekitten.com" in url:

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High test

The string
placekitten.com
Loading
may be at an arbitrary position in the sanitized URL.

Copilot Autofix AI 3 days ago

To fix the problem, we need to parse the URL and check the hostname specifically, rather than looking for a substring within the entire URL. This ensures that we accurately identify and exclude URLs from "placekitten.com" and its subdomains.

The best way to fix this is to use the urlparse function from the urllib.parse module to extract the hostname from the URL and then check if it matches "placekitten.com". This approach is more robust and prevents bypassing the check by embedding "placekitten.com" in other parts of the URL.

Suggested changeset 1
autogpt_platform/backend/test/test_data_creator.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/autogpt_platform/backend/test/test_data_creator.py b/autogpt_platform/backend/test/test_data_creator.py
--- a/autogpt_platform/backend/test/test_data_creator.py
+++ b/autogpt_platform/backend/test/test_data_creator.py
@@ -41,5 +41,7 @@
 
+from urllib.parse import urlparse
+
 def get_image():
     url = faker.image_url()
-    while "placekitten.com" in url:
+    while urlparse(url).hostname == "placekitten.com":
         url = faker.image_url()
EOF
@@ -41,5 +41,7 @@

from urllib.parse import urlparse

def get_image():
url = faker.image_url()
while "placekitten.com" in url:
while urlparse(url).hostname == "placekitten.com":
url = faker.image_url()
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Swiftyos Swiftyos

Labels
conflicts Automatically applied to PRs with merge conflicts platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 4 size/xl
Projects
AutoGPT development kanban
Status: 🆕 Needs initial review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftyos @ntindle @Bentlybro