-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Fix .env file read contention on pyro connection setup #8736
base: dev
Are you sure you want to change the base?
Conversation
…tion-to-async' into zamilmajdy/revert-converted-function-to-async
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
@majdyz is this related to today's outage? Because we don't read from .env |
@aarushik93 unrelated, just something I found during the local test. |
Can you explain a bit more, the PR description doesn't really explain to me what the issue is or what its fixing |
On high concurrent pyro connections initialization, the .env file being on the high read contention causing connection establishment to fail.
Changes 🏗️
Move all the usage of. Config as a globally initialized variable.
Checklist 📋
For code changes:
Example test plan
For configuration changes:
.env.example
is updated or already compatible with my changesdocker-compose.yml
is updated or already compatible with my changesExamples of configuration changes