Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to nonmonotone linesearch #244

Merged
merged 19 commits into from
Dec 9, 2024
Merged

Switch to nonmonotone linesearch #244

merged 19 commits into from
Dec 9, 2024

Conversation

ManifoldFR
Copy link
Member

Switch to the nonmonotone linesearch

small tweak of ur10_ballistic

acrobot: change default params

HistoryCallback: pass solver pointer as argument to templated ctor

examples: python: change HistoryCallback() calls

re-tune cartpole.py

update quadrotor_obstacles.py

Add separate mu_init for non-bound constrained setting

[utils/plotting] some enhancements to plotting convergence diagrams

[examples] re-tune some problems, plot convergence

Update plotting.py again:

  • decide labels automatically
  • only add "AL iters" label when there are 2 iters

update solo_jump.py

solo_jump : greatly increase joint-space weight

solo_jump : add spinning

solo_jump : flight phase target irrelevant

solo_jump : spin further, fix landing fn

ur10_ballistic : load_projectile_model() can take free flyer or not

  • adjust rigid constraint model factory, pass contact type

[examples] ur10_ballistic.py : sanely distinguish original model nq, nv from model with projectile's nq, nv

plotting.py : get legend first before adding other labels

ask for tighter tolerance on cartpole

quadrotor_obstacles : use the plotting util

@ManifoldFR
Copy link
Member Author

ManifoldFR commented Nov 1, 2024

This change is part of the following stack:

Change managed by git-spice.

@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch from 8678f9a to e30fd08 Compare November 1, 2024 17:04
This was referenced Nov 1, 2024
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch 2 times, most recently from 1a2e08d to 385f2de Compare November 1, 2024 17:31
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch from 385f2de to 99bc5ce Compare November 1, 2024 17:34
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch 2 times, most recently from c702d3b to 0e603c4 Compare November 2, 2024 01:33
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch from 0e603c4 to edfdc97 Compare November 4, 2024 16:55
Base automatically changed from topic/gar/devel to devel November 4, 2024 22:19
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch 7 times, most recently from a2b2e0e to 40b0baa Compare November 5, 2024 09:57
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch 8 times, most recently from dd457e3 to d88e2a5 Compare November 16, 2024 18:37
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch 4 times, most recently from 6b2dcc0 to c089f5b Compare December 4, 2024 18:36
examples: python: change HistoryCallback() calls

test_constrained_dynamics : no use for HistoryCallback() here.

fix ur5_reach.py
quadrotor_obstacles: Add separate mu_init for non-bound constrained setting
- decide labels automatically
- only add "AL iters" label when there are 2 iters
- get legend first before adding other labels

[examples] re-tune some problems, plot convergence

update solo_jump.py

+ greatly increase joint-space weight
+ add spinning
+ flight phase target irrelevant
+ spin further, fix landing fn
…nv from model with projectile's nq, nv

ur10_ballistic : load_projectile_model() can take free flyer or not

+ adjust rigid constraint model factory, pass contact type
@ManifoldFR ManifoldFR force-pushed the topic/nonmonotone-ls branch from c089f5b to 07ea041 Compare December 4, 2024 18:38
…lter linesearch using enum + variant

Add header aligator/overloads.hpp (for overloaded lambda visitor pattern)
@ManifoldFR ManifoldFR marked this pull request as ready for review December 4, 2024 21:40
@ManifoldFR ManifoldFR requested a review from edantec December 4, 2024 21:40
remove fallback for SA_LINESEARCH in Python
@ManifoldFR
Copy link
Member Author

This PR is finally ready for review.

@ManifoldFR ManifoldFR enabled auto-merge December 5, 2024 00:20
Copy link
Collaborator

@edantec edantec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions but otherwise the PR seems ok

include/aligator/core/linesearch-nonmonotone.hpp Outdated Show resolved Hide resolved
include/aligator/core/linesearch-nonmonotone.hpp Outdated Show resolved Hide resolved
tests/python/test_solver.py Show resolved Hide resolved
@ManifoldFR ManifoldFR disabled auto-merge December 9, 2024 18:37
@ManifoldFR ManifoldFR merged commit b4b0b1f into devel Dec 9, 2024
28 checks passed
@ManifoldFR ManifoldFR deleted the topic/nonmonotone-ls branch December 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants