Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect local URLs on an index_no_slash.html #181

Open
raphCode opened this issue Mar 17, 2022 · 2 comments
Open

Incorrect local URLs on an index_no_slash.html #181

raphCode opened this issue Mar 17, 2022 · 2 comments

Comments

@raphCode
Copy link
Contributor

When the URL does not end with an slash, the downloaded file becomes index_no_slash.html.
But the converted local links are wrong, because url.join() is called, and since the URL does not end with an slash, it strips away the last folder, thinking it is a file.

I made a hackish fix here: https://github.com/raphCode/suckit/tree/hack_url_fix
Not sure if you want to merge, feel like a mess.

@star2202
Copy link

star2202 commented Apr 20, 2022

@raphCode hey bro
I am getting an Downloader.get() has encountered an error:
still got the same error with your variant as well
any idea how can I fix this it's sort of confusing for my little no coding knowledge brain
image

@Skallwar
Copy link
Owner

Put a '/' after '.com', it should fix this.

Sorry for the delay in a lot of fixes and issues, I don't have a lot of free time these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants