Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateChecker - GithubChecker/ReleaseChannel Improper checks #7263

Open
1 task done
Fusezion opened this issue Dec 15, 2024 · 0 comments
Open
1 task done

UpdateChecker - GithubChecker/ReleaseChannel Improper checks #7263

Fusezion opened this issue Dec 15, 2024 · 0 comments

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Dec 15, 2024

Skript/Server Version

[04:06:32 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[04:06:32 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[04:06:32 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[04:06:32 INFO]: [Skript] Server Version: 1.21.3-81-da71382 (MC: 1.21.3)
[04:06:32 INFO]: [Skript] Skript Version: 2.10.0-beta1 (skriptlang-github)
[04:06:32 INFO]: [Skript] Installed Skript Addons:
[04:06:32 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[04:06:32 INFO]: [Skript]  - Skuishy v2.8.1 (https://aabss.cc)
[04:06:32 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[04:06:32 INFO]: [Skript] Installed dependencies:
[04:06:32 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

When skript releases a new version and the user is currently using a beta/alpha/prerelease ReleaseChannel the channel's ReleaseChannel#check method will always default to True since that allows non-stable releases.

However when skript makes a release for an older version say 2.9.5 after said beta when GithubChecker runs through their releases they always set the first release at the "latest" release

// Check if this is a suitable latest release
if (latest == null && channel.check(name)) {
latest = release;
}

Expected Behavior

Skript to properly check against Version hopefully using their own Version class

Steps to Reproduce

Run skript-2.10.0-beta1 on any supported server version

Errors or Screenshots

image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant