-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lantern not working #92
base: master
Are you sure you want to change the base?
Conversation
Fix lantern not working
@@ -655,7 +655,7 @@ nether update: | |||
any campfire = campfire, soul campfire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require optional brackets as well?
Does this not conflict with regular lanterns? Also, there are two instances of |
Agree with @APickledWalrus, seems like this will conflict with the normal (non-soul) As for this, Pickle...
I assume you mean the ones in "nether update" and "nether update part 2"? If so, the 2nd one is overriding the first one to include the |
Point out where it's defined twice. |
My main concern here is that this overrides the existing alias for just regular lanterns. There is then no good way to just give the user or check for a "normal" lantern early, and I do not feel that requiring |
Fix lantern not working.
on place of lantern
does not work, you had to useany lantern
to fix that issue.