Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lantern not working #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix lantern not working #92

wants to merge 1 commit into from

Conversation

TheLimeGlass
Copy link
Contributor

@TheLimeGlass TheLimeGlass commented Jul 13, 2023

Fix lantern not working. on place of lantern does not work, you had to use any lantern to fix that issue.

Fix lantern not working
@TheLimeGlass TheLimeGlass added the bug Something isn't working label Jul 13, 2023
@@ -655,7 +655,7 @@ nether update:
any campfire = campfire, soul campfire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require optional brackets as well?

@APickledWalrus
Copy link
Member

APickledWalrus commented Jul 13, 2023

Does this not conflict with regular lanterns? Also, there are two instances of any lantern(so if you're making changes, you'll need to change both)

@TheBentoBox
Copy link
Member

Agree with @APickledWalrus, seems like this will conflict with the normal (non-soul) lantern alias. There seems to be a different issue at play here if on place of lantern doesn't work.

As for this, Pickle...

Also, there are two instances of any lantern

I assume you mean the ones in "nether update" and "nether update part 2"? If so, the 2nd one is overriding the first one to include the {waterloggable} overrides for lanterns from lines 670 and 671.

@TheLimeGlass
Copy link
Contributor Author

Does this not conflict with regular lanterns? Also, there are two instances of any lantern(so if you're making changes, you'll need to change both)

Point out where it's defined twice.

@APickledWalrus
Copy link
Member

It's defined here

{lantern hanging} lantern = minecraft:lantern
and again here
{waterloggable} {lantern hanging} lantern = minecraft:lantern
due to some changes with the data the block supports

@TheLimeGlass
Copy link
Contributor Author

It's defined here

{lantern hanging} lantern = minecraft:lantern

and again here

{waterloggable} {lantern hanging} lantern = minecraft:lantern

due to some changes with the data the block supports

It will redefine it

@APickledWalrus
Copy link
Member

My main concern here is that this overrides the existing alias for just regular lanterns. There is then no good way to just give the user or check for a "normal" lantern early, and I do not feel that requiring normal lantern is an ideal approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants