-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom effect can't modify converted expressions via raw expression #122
Comments
not unheard of I'd probably wait for a member of the org to respond as it was responded with in under 10 seconds of making this issue |
Temporarily fixed this issue By adding a piece of codes: +import:
+ ch.njol.skript.classes.Changer
+ ch.njol.skript.lang.util.ConvertedExpression
effect bind %item% to %offline player%:
trigger:
set {_i} to expr-1
set string tag "bind" of custom nbt of {_i} to name of expr-2 # from SkBee addon
+ if (the raw expr-1) is an instance of ConvertedExpression:
+ (the raw expr-1).acceptChange(Changer.ChangeMode.SET)
set the raw expr-1 to {_i}
command /bindtest <offline player>:
permission: jing.op
trigger:
bind tool of player to arg-1 The thing is, a converted expression won't use I know very little of how the script system works, so I don't know how to fix this in a better way and only made this simple fix. Needs someone knowing the system well to eventually fix this. |
Describe the bug
when change value of a
ConvertedExpression
instance on custom effect, the trigger stops and generates an error like this:To reproduce
use the script below to reproduce:
Expected behavior
Modify the
ConvertedExpression
normally, like in the origin skript effects.Screenshots
Server information
Additional context
If we change a variable instead of a converted expression, the custom effect works well:
The text was updated successfully, but these errors were encountered: