From 1083e23d01d4b9069c763296872e79088c6571b0 Mon Sep 17 00:00:00 2001 From: Evan Young Date: Sat, 11 Dec 2021 00:55:09 -0800 Subject: [PATCH] Updates a budget to about double (just to put something in there) and adds the check against the budget back into the lighthouse workflow. --- .github/workflows/lighthouse.yml | 3 +-- .gitignore | 5 ++++- lighthouse-budget.json | 8 ++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 661446ef3..6a2b5c6e6 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -46,6 +46,5 @@ jobs: urls: | ${{ steps.netlify.outputs.url }} ${{ steps.netlify.outputs.url }}/momentum/ - # TODO ERY: We will need to add this back in the future, but we need to deliberate on what we find an acceptable lighthouse budget to be - # budgetPath: ./lighthouse-budget.json + budgetPath: ./lighthouse-budget.json uploadArtifacts: true diff --git a/.gitignore b/.gitignore index 424d017be..adfe2b89c 100644 --- a/.gitignore +++ b/.gitignore @@ -40,4 +40,7 @@ yarn-error.log* .env # Auto generated images -public/content \ No newline at end of file +public/content + +# Netlify +/.netlify/ \ No newline at end of file diff --git a/lighthouse-budget.json b/lighthouse-budget.json index 4ab8665c4..f1779997f 100644 --- a/lighthouse-budget.json +++ b/lighthouse-budget.json @@ -8,23 +8,23 @@ }, { "metric": "first-meaningful-paint", - "budget": 2000 + "budget": 5000 } ], "resourceSizes": [ { "resourceType": "script", - "budget": 150 + "budget": 500 }, { "resourceType": "total", - "budget": 500 + "budget": 1000 } ], "resourceCounts": [ { "resourceType": "third-party", - "budget": 100 + "budget": 200 } ] }