Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing Accept header of newer Chrome fails #56

Open
eikek opened this issue Mar 29, 2019 · 4 comments
Open

Parsing Accept header of newer Chrome fails #56

eikek opened this issue Mar 29, 2019 · 4 comments

Comments

@eikek
Copy link
Contributor

eikek commented Mar 29, 2019

Hi,
from some Android device running Chrome 73, the following Accept header is sent

Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3

The parser fails on the last v= part, saying expecting a q= instead:

Decoding of the request header failed: Headers/Accept/6: expected constant BitVector(16 bits, 0x713d) but got BitVector(16 bits, 0x763d)

I don't know what v= means. The user agent string is Mozilla/5.0 (Linux; Android 7.0; Lenovo TB-7304F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.90 Safari/537.36 and I'm using protocol-http version 0.3.12.

@AdamChlupacek
Copy link
Member

@eikek Hello there,

Sorry for a bit delayed response, I have found out the issue, and made a fix for it #57 , it should be merged in during next week (0.3.18-SNAPSHOT) and then by the end of the week we may do full release.

Hope it is fine.

@eikek
Copy link
Contributor Author

eikek commented Apr 22, 2019

@AdamChlupacek Thank you! And no worries about delays.

@AdamChlupacek
Copy link
Member

@eikek The snapshot is now released with this change, we are not doing full release yet as there is not enough changes from the last version yet, be free to use 0.3.18-SNAPSHOT, it is stable. We are using it in production as well.

@eikek
Copy link
Contributor Author

eikek commented Apr 30, 2019

Thanks @AdamChlupacek ; I now created a workaround such that all headers that failed to parse are ignored (mapped to empty values). For my apps that is just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants