-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SpeziScheduler 1.0 #84
Conversation
d4d8988
to
847f397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool to see the simplifications in here!
TemplateApplication/Schedule/TemplateApplicationScheduler.swift
Outdated
Show resolved
Hide resolved
TemplateApplication/Schedule/TemplateApplicationScheduler.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this; happy to see this merged once we move to fully tagged version in the template app; we should also move Foundation, Accounts, and others to the tagged versions that are not betas 👍
TemplateApplication.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
TemplateApplication.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
@PSchmiedmayer it seems like periphery doesn’t support swift 6? Or do you have a clue what the issue could be with the failing build? |
Seem like this might be resolved soon: peripheryapp/periphery#813 Wondering we should temporarily remove CodeQL and Periphery and add an issue to re-add them once they support Xcode 16/Swift 6? Or maybe make them non-required to merge a PR? |
I think making Peripheral optional makes sense. They seem to be working on this. Not sure how long it takes for CodeQL to support Swift 6. Other than that, this PR is ready to be merged 👍 |
Good point; I think we can make both optional for now but keep the actions in there. I have asked for an estimate on the CodeQL Swift 6 adoption in their GitHub repo: github/codeql-action#2506. It seems like some of the UI tests are still failing at this point; I would be fine with going ahead and merging the PR with CodeQL and Periphery failing for now (they will work again once support is added to these tools). |
Just found, that Periphery only fails because of the project format being Xcode 16.0. I just reverted to the Xcode 15.3 project format as it isn't really important and periphery works again. Now we are just waiting for CodeQL. Another thing I noticed was that the Build and Test currently always choses the iPhone SE which makes some of our unit test fail as we would need to add additional behavior for scrolling. I tried to change the device to iPhone 16 Pro in Fastlane, however that didn't do anything. Do you know what the issue might be? |
Very cool; that's great regarding Periphery! Strange thing regarding the simulator; must be related to what simulators are installed on the runners. I thought all of them should be installed, but there might be a mismatch ... |
@Supereg I updated some of our agents and the builds seem to run now; just seems to be a UI testing issue with our license test that would stop us from merging the PR 👍 |
Great news. I’ll make sure to resolve that 👍 |
Thank you 🎉 |
Apparently, this was just a Springboard Reboot in the Simulator while executing this test case. Everything passes now. |
Update to SpeziScheduler 1.0
♻️ Current situation & Problem
This PR updates the SpeziTemplateApplication to use the new SpeziScheduler 1.0 release. This allow use to remove a lot of code that was previously necessary in the template application. Generally, we were able to greatly simplify the Scheduler setup.
⚙️ Release Notes
📚 Documentation
We updated the documentation to reflect the changes done to the template app.
✅ Testing
Existing UI test cases are reused.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: