Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minim audio library errors printed to console #138

Open
Stephcraft opened this issue Mar 15, 2020 · 4 comments
Open

Fix minim audio library errors printed to console #138

Stephcraft opened this issue Mar 15, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs

Comments

@Stephcraft
Copy link
Owner

The audio in the project is handled by the Minim library. This library is yelling errors at runtime. The sources of the errors are unknown and a solution must be established to fix the errors.

Here are the errors:

=== JavaSound Minim Error ====
==== Don't know the ID3 code TSS

==== JavaSound Minim Error ====
==== Error parsing ID3v2: String index out of range: -131

==== JavaSound Minim Error ====
==== Don't know the ID3 code TSS

==== JavaSound Minim Error ====
==== Error parsing ID3v2: String index out of range: -131

==== JavaSound Minim Error ====
==== Don't know the ID3 code TSS

==== JavaSound Minim Error ====
==== Error parsing ID3v2: String index out of range: -131

==== JavaSound Minim Error ====
==== Don't know the ID3 code TSS

==== JavaSound Minim Error ====
==== Error parsing ID3v2: String index out of range: -131
@Stephcraft Stephcraft added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs labels Mar 15, 2020
@micycle1
Copy link
Collaborator

These errors are simply saying the mp3 files have no tags.

@mapuya19
Copy link

Do we want to add tags to the MP3 files then?

@Stephcraft
Copy link
Owner Author

@mapuya19 If it's possible to fix the errors or hide this specific type of error, it would be the best. It seems like the tags metadata does not exist or maybe its value is invalid: String index out of range: -131. But simply adding tags is fine if nothing else works.

@fstuff
Copy link

fstuff commented May 31, 2021

This is really an issue with the Minim library. It has unsophisticated error logging that can't be configured or turned off. In reality the "errors" being logged are really just warnings. The code in the Minim library just prints all such messages to the System.out stream, and there's no way to configure it. Barring a major revision in Minim to the way ID3 parse errors are handled, there is nothing that can be done here other than to clean up the project mp3 files.

As for the logged errors in the original post above, they are explained as follows:
__==== Don't know the ID3 code TSS
Based on my review of the Minim source code, the Minim library doesn't have support for that ID3 tag. The MP3s in Project-16x16 are tagged with version ID3v2.2. According to the ID3v2.2 spec the TSS flag is:

The 'Software/hardware and settings used for encoding' frame includes the used audio encoder and its settings when the file was encoded. Hardware refers to hardware encoders, not the computer on which a program was run.
It does not seem so important to maintain that tag in the MP3s, so if the extraneous error log is annoying enough, the tag can be removed.

__==== Error parsing ID3v2: String index out of range: -131
I'm not sure exactly why this is happening--the only other tags on the mp3 files in the project are comments. The "error" does not affect the operation of the Minim library.

So, if the ID3 tags are stripped out of the mp3 project files, it should eliminate the noisy warnings ("errors").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants